Skip to content

Update REXML (from ruby MRI)#1752

Merged
dbussink merged 3 commits intorubinius:masterfrom
LTe:update_rexml
May 28, 2012
Merged

Update REXML (from ruby MRI)#1752
dbussink merged 3 commits intorubinius:masterfrom
LTe:update_rexml

Conversation

@LTe
Copy link
Copy Markdown
Contributor

@LTe LTe commented May 27, 2012

Related to #1743

@travisbot
Copy link
Copy Markdown

This pull request fails (merged 22baa6ab into c2b50c2).

@dbussink
Copy link
Copy Markdown
Contributor

Did you run 'rake' after merging these changes? It looks like it causes build failures, at least on Travis.

@travisbot
Copy link
Copy Markdown

This pull request fails (merged 450f6d81 into c2b50c2).

@travisbot
Copy link
Copy Markdown

This pull request fails (merged 901a008d into c2b50c2).

@LTe
Copy link
Copy Markdown
Contributor Author

LTe commented May 28, 2012

Updated version of REXML use ::Encoding::Converter.search_convpath (https://github.com/LTe/rubinius/commit/18dc9291204baaa4c0c1cbc1b1c7413a213207cc#L11R55) and all specs for this method have a fail tag (https://github.com/rubinius/rubinius/blob/master/spec/tags/19/ruby/core/encoding/converter/search_convpath_tags.txt)

I added empty implementation for this method. Now all specs pass.

@dbussink
Copy link
Copy Markdown
Contributor

Looks like the pull request is somehow screwed up since there's a bunch of stuff already in master now in the pull request. Could you make a clean one so it isn't mixed with all kinds of other stuff?

Maybe adding a TODO in the empty method would be useful so we remember to add it?

@LTe
Copy link
Copy Markdown
Contributor Author

LTe commented May 28, 2012

@dbussink rebased to master

@travisbot
Copy link
Copy Markdown

This pull request passes (merged 65e6ebc into f0b98aa).

dbussink added a commit that referenced this pull request May 28, 2012
Update REXML (from ruby MRI)
@dbussink dbussink merged commit 0672a14 into rubinius:master May 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants