Array#join executed with nil should use default separator#1829
Merged
dbussink merged 1 commit intorubinius:masterfrom Jul 25, 2012
LTe:separator_test
Merged
Array#join executed with nil should use default separator#1829dbussink merged 1 commit intorubinius:masterfrom LTe:separator_test
dbussink merged 1 commit intorubinius:masterfrom
LTe:separator_test
Conversation
Contributor
There was a problem hiding this comment.
You probably want to make sure to restore $, to the old value afterwards.
It would be very weird if because of that somebody would get a spec failure in another spec depending on whether this spec has ran or not.
Contributor
Author
dbussink
added a commit
that referenced
this pull request
Jul 25, 2012
Array#join executed with nil should use default separator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add specs for join with nil argument.
ruby/ruby@61a67bc
http://bugs.ruby-lang.org/issues/5915