Add NonLocalExitFromIterator lint and fix other cops complained by it#1728
Merged
bbatsov merged 2 commits intorubocop:masterfrom Mar 23, 2015
Merged
Add NonLocalExitFromIterator lint and fix other cops complained by it#1728bbatsov merged 2 commits intorubocop:masterfrom
bbatsov merged 2 commits intorubocop:masterfrom
Conversation
Contributor
Author
|
jshint has |
Collaborator
|
👍 I like this cop. Just had a few comments. BTW, the equivalent to |
Collaborator
|
Small remark from me - please, capitalize commit messages. |
f142e04 to
562de6c
Compare
Contributor
Author
I was thinking it is verbose a little, but it is simple enough for something rarely used :) Thanks for reviewing! Fixed for all comments. Rebased, CHANGELOG added. |
Collaborator
|
@ypresto You'll have to rebase again. Sorry about this. |
- Fixed: AssignmentInCondition, LiteralInInterpolation - Code style change: UnneededCapitalW
562de6c to
9ddb8f0
Compare
Contributor
Author
|
re-rebased! |
bbatsov
added a commit
that referenced
this pull request
Mar 23, 2015
Add NonLocalExitFromIterator lint and fix other cops complained by it
Collaborator
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found bug in our product that aborts iterator unexpectedly, with return statement.
NonLocalExitFromIterator detects misused return statements in iterator block.
It uses heuristic way to distinguish intended use of return or not:
Because where
nextshould be used tend to have no return value (but ofmap).E.g.
array.each do |item| ... endand notbefore_fork do |server| ... end.E.g. not
foobar.with_lock do ... end.Cops affect with this bug also found: LiteralInInterpolation and AssignmentInCondition.
UnneededCapitalW is false-positive, but is still easy to use
any?instead.Thanks for great product!