Skip to content

Feature/crafting hide tanning#346

Merged
Tynarus merged 14 commits intorunejs:feature/crafting-skillfrom
SchauweM:feature/crafting-hide-tanning
Sep 30, 2021
Merged

Feature/crafting hide tanning#346
Tynarus merged 14 commits intorunejs:feature/crafting-skillfrom
SchauweM:feature/crafting-hide-tanning

Conversation

@SchauweM
Copy link
Copy Markdown
Collaborator

@SchauweM SchauweM commented Sep 30, 2021

Crafting - Hide tanning

This PR introduces the ability to tan all possible hides at Ellis.

Features

  • Added the Ellis NPC in Al-Kharid.
  • Added the "Hide Tanning" interface with all logic.
  • Fixed an issue with the player.hasCoins() function and converted it to player.hasEnoughCoins(amount) which will return the default You don't have enough coins.message
  • Added the player.removeCoins() function

@SchauweM SchauweM added new feature A new feature or request plugins Updates involving content plugins labels Sep 30, 2021
@SchauweM SchauweM requested review from a team and Promises September 30, 2021 10:27
@Tynarus
Copy link
Copy Markdown
Member

Tynarus commented Sep 30, 2021

image

Copy link
Copy Markdown
Member

@Tynarus Tynarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Moar content 😍
Few smol comments, nothing major. :)

Comment thread src/game-engine/world/actor/player/player.ts Outdated
Comment thread src/plugins/skills/crafting/tanning-hides/tanning-hides-interface.plugin.ts Outdated
Comment thread src/plugins/skills/crafting/tanning-hides/tanning-hides-interface.plugin.ts Outdated
@Tynarus Tynarus merged commit 3e1f132 into runejs:feature/crafting-skill Sep 30, 2021
@SchauweM SchauweM deleted the feature/crafting-hide-tanning branch September 30, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature A new feature or request plugins Updates involving content plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants