Open
Conversation
DwardEE
approved these changes
Nov 25, 2025
DwardEE
left a comment
There was a problem hiding this comment.
Good work!
No changes are needed. Everything looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding the pdfs of the LDMs for the bookstore (2 files)
Adding the assignment2.md markdown file with the answer to the question on SCD Type 1 and Type 2
Adding the Assignment2.sql file with the completed exercises
What did you learn from the changes you have made?
I learned that getting good at SQL takes a lot of practice
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Had a lot of challenges in getting the SQL queries to work for some of the questions, especially the last one - had to look up the topics again around using coalesce in an update statement, using multiple CTEs and then referring to them to do ranking etc.
How were these changes tested?
I ran everything in SQLite DB browser, for the more complex changes, I ran them one at a time to make sure the steps were giving the correct outcomes.
A reference to a related issue in your repository (if applicable)
Checklist