ToggleButtonLayout: Add self reference to OnToggledListener callback#17
Merged
Jawnnypoo merged 1 commit intosavvyapps:masterfrom Jun 7, 2019
Merged
ToggleButtonLayout: Add self reference to OnToggledListener callback#17Jawnnypoo merged 1 commit intosavvyapps:masterfrom
Jawnnypoo merged 1 commit intosavvyapps:masterfrom
Conversation
* Also provide ToggleButtonLayout reference per Toggle * Fixes savvyapps#10 Signed-off-by: Brandon McAnsh <[email protected]>
Jawnnypoo
reviewed
Jun 7, 2019
| * Listen for when toggles get selected and deselected | ||
| */ | ||
| var onToggledListener: ((toggle: Toggle, selected: Boolean) -> Unit)? = null | ||
| var onToggledListener: ((v: View?, toggle: Toggle, selected: Boolean) -> Unit)? = null |
Contributor
There was a problem hiding this comment.
Can we make v: View? into toggleButtonLayout: ToggleButtonLayout? instead?
Contributor
|
This does break binary compatibility unfortunately, so it would need a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also provide ToggleButtonLayout reference per Toggle
Fixes Ability to get ToggleButtonLayout from Toggle #10
Signed-off-by: Brandon McAnsh [email protected]