feature: #176, insert_picture: added optional parameters crop & vcenter#439
Open
aatwork wants to merge 3 commits intoscanny:masterfrom
Open
feature: #176, insert_picture: added optional parameters crop & vcenter#439aatwork wants to merge 3 commits intoscanny:masterfrom
aatwork wants to merge 3 commits intoscanny:masterfrom
Conversation
…nd vcenter. backward compatible. default behavior remains unchanged
|
@aatwork Could you also add an hcenter flag to this? You did most of the work already it just requires the same logic and arguments as vcenter, like the following at line 349 And add hcenter to the arguments at lines 313, 323, 327 |
|
Incredibly useful, thanks a lot. |
Author
|
@adamerose |
|
It looks like the tests need to be updated to account for the new function arguments. I don't have any experience with this type of thing, but it looks like something such as this: Might fix the tests so the travis-ci build succeeds. Perhaps worth updating your pull request with this or something better that achieves the same result. |
|
@scanny , Any chances this will be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables the functionality requested in #176
The change is backward compatible because the defaults for the new arguments correspond to the previous behavior.
if crop argument is set to False, the image will be scaled proportionally to be able to fit into the placeholder
if vcenter is set to True, the image will be centered vertically