Conversation
The defualt log level was previously set to WARN, meaning INFO-level logging and above would not be output. This was confusing, as INFO statements were intended to be used to convey basic, helpful information. To that end, the default level has been dropped down to INFO. This also required updating log.info statements that were outputting DEBUG-style information to be similarly adjusted to log.debug statements.
Having this as a WARN-level log statement is overly aggressive. No exceptions were thrown, and skipping a non-existant directory is expected behavior, thus this statement is downgraded to DEBUG-level.
Member
Author
|
@ctrueden are you happy with all these logging priority changes? |
ctrueden
added a commit
that referenced
this pull request
Dec 19, 2014
Make INFO the default log level
Member
|
Perfect, thank you. 🏆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality of life update - changes default log level to INFO, and lowers the priority of the ScriptFinder's warning to debug, to avoid unnecessary warnings.
Closes #137.