Fix logical error preventing SSH content matching#288
Merged
s-newman merged 2 commits intoscorestack:devfrom Feb 16, 2021
sourque:dev
Merged
Fix logical error preventing SSH content matching#288s-newman merged 2 commits intoscorestack:devfrom sourque:dev
s-newman merged 2 commits intoscorestack:devfrom
sourque:dev
Conversation
s-newman
approved these changes
Feb 16, 2021
Collaborator
s-newman
left a comment
There was a problem hiding this comment.
Nice catch, and thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello friends, this is a small (one character) change that should handle the SSH MatchContent field correctly. I haven't tested it locally, but due to it being a tiny change, I assume it won't have any unforeseen collateral damage. I think these two structures were mixed:
Match content when false
Match content when true
Into don't match content when true
Merge Checklist
dev, unless it's a PR for a release