Merged
Conversation
That's what it originally was
I'm not really sure how we'd do it with Ansible, and I don't think I want to figure that out right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our Kibana visualizations depended on the field mappings that Logstash created for the results indices, and the switch away from libbeat in #302 broke these visualizations. This PR creates the result indices with the same mappings and settings as Logstash used to create. In the process, each result index pattern has been merged into a single index. Additionally, some refactoring took place in Dynamicbeat to make it simpler to create check results and index them.
Merge Checklist
dev, unless it's a PR for a release