Fix segfault on check parse fail in dynamicbeat#316
Merged
s-newman merged 1 commit intoscorestack:devfrom Apr 20, 2021
Merged
Conversation
s-newman
approved these changes
Apr 20, 2021
Collaborator
|
Thanks for the contribution! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes the previous behavior of dynamicbeat crashing when an invalid check is parsed. This is called from
dynamicbeat setup checksand would happen when adding checks to elastic, by accessing a null pointer. As the error is passed to Errorf() this still by zap's defaults results in a large stack trace, but dynamicbeat will try to upload the next check as expected. Disabling stack traces on logs like this is possible using the documentation here.Fixes #305
Merge Checklist
dev, unless it's a PR for a release