Skip to content

Fix Template Overrides#324

Merged
s-newman merged 2 commits intodevfrom
override-template-bugfix
Sep 29, 2021
Merged

Fix Template Overrides#324
s-newman merged 2 commits intodevfrom
override-template-bugfix

Conversation

@s-newman
Copy link
Copy Markdown
Collaborator

@s-newman s-newman commented Sep 29, 2021

Description

This PR fixes a bug in the team override system that caused any checks using the template-based override method to fail. This was because the wrong map was being used to execute the attribute value templates, so the overrides were never being used.

Replacement overrides are not affected by this bug, and work as expected.

Merge Checklist

  • I have tested this change locally to make sure it works
  • I have updated the documentation as necessary
  • I have added a release note under the Unreleased section of the Changelog
  • Any relevant labels have been added
  • This PR is being merged into dev, unless it's a PR for a release

@s-newman s-newman added T-Bug Something isn't working the way it should be A-Dynamicbeat Relates to Dynamicbeat S-Actionable Someone could pick this issue up and work on it right now labels Sep 29, 2021
@s-newman
Copy link
Copy Markdown
Collaborator Author

Well, I did update the changelog, but the update was pushed to dev. Oh well.

@s-newman s-newman merged commit 5b7fe0c into dev Sep 29, 2021
@s-newman s-newman deleted the override-template-bugfix branch September 29, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Dynamicbeat Relates to Dynamicbeat S-Actionable Someone could pick this issue up and work on it right now T-Bug Something isn't working the way it should be

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant