fix failed install output#1115
Merged
glennblock merged 1 commit intoscriptcs:devfrom Nov 3, 2015
adamralph:1114-fix-failed-install-output
Merged
fix failed install output#1115glennblock merged 1 commit intoscriptcs:devfrom adamralph:1114-fix-failed-install-output
glennblock merged 1 commit intoscriptcs:devfrom
adamralph:1114-fix-failed-install-output
Conversation
Member
|
you should unwrap or hide the AggregateException |
Contributor
Author
|
This PR fixes the bug. We can talk about how to unwrap separately. |
Contributor
|
First awesome! Second, we should probably have a generic utility to do unwrapping. On Tue, Nov 3, 2015 at 10:53 AM Adam Ralph [email protected] wrote:
|
Contributor
Author
|
We probably should do something with the aggregate exception, but we can spin off a separate issue for that. This PR fixes the bug #1114 and should be good to merge. |
Member
|
For reference, see Nancy's ExceptionExtensions for flattening/unwrapping an |
Contributor
|
Thanks @adamralph |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1114