Skip to content

#297 fix loading of script packs when auto installing#697

Merged
glennblock merged 1 commit intoscriptcs:devfrom
adamralph:297
May 18, 2014
Merged

#297 fix loading of script packs when auto installing#697
glennblock merged 1 commit intoscriptcs:devfrom
adamralph:297

Conversation

@adamralph
Copy link
Copy Markdown
Contributor

fixes #297

@adamralph
Copy link
Copy Markdown
Contributor Author

image

@adamralph
Copy link
Copy Markdown
Contributor Author

To summarise the change: when creating the composite install and script command, a 'deferred creation command' is returned instead of the script command which invokes a factory delegate when executed to actually create the underlying command. This delegate creates it's own set of services, which see the newly installed script packs so everything works as expected. This takes advantage of the script services builder factory introduced for the watch command changes.

@glennblock
Copy link
Copy Markdown
Contributor

Good find @adamralph!

glennblock added a commit that referenced this pull request May 18, 2014
#297 fix loading of script packs when auto installing
@glennblock glennblock merged commit fa7db7a into scriptcs:dev May 18, 2014
@glennblock
Copy link
Copy Markdown
Contributor

As a side note, I think we need to be careful that the command factory doesn't get out of control implementation / complexity wise. It's on its way there now, which started with the merging of the watch functionality.

@adamralph adamralph deleted the 297 branch May 18, 2014 23:47
@khellang khellang added this to the v0.10 milestone Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Script packs not loaded when automatically installing NuGet packages

3 participants