#297 fix loading of script packs when auto installing#697
Merged
glennblock merged 1 commit intoscriptcs:devfrom May 18, 2014
adamralph:297
Merged
#297 fix loading of script packs when auto installing#697glennblock merged 1 commit intoscriptcs:devfrom adamralph:297
glennblock merged 1 commit intoscriptcs:devfrom
adamralph:297
Conversation
Contributor
Author
Contributor
Author
|
To summarise the change: when creating the composite install and script command, a 'deferred creation command' is returned instead of the script command which invokes a factory delegate when executed to actually create the underlying command. This delegate creates it's own set of services, which see the newly installed script packs so everything works as expected. This takes advantage of the script services builder factory introduced for the watch command changes. |
Contributor
|
Good find @adamralph! |
glennblock
added a commit
that referenced
this pull request
May 18, 2014
#297 fix loading of script packs when auto installing
Contributor
|
As a side note, I think we need to be careful that the command factory doesn't get out of control implementation / complexity wise. It's on its way there now, which started with the merging of the watch functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #297