Skip to content

#785 Copy binaries to artifacts folder in build.sh#824

Closed
mbaker-dev wants to merge 1 commit intoscriptcs:devfrom
mbaker-dev:dev
Closed

#785 Copy binaries to artifacts folder in build.sh#824
mbaker-dev wants to merge 1 commit intoscriptcs:devfrom
mbaker-dev:dev

Conversation

@mbaker-dev
Copy link
Copy Markdown
Contributor

No description provided.

@mbaker-dev mbaker-dev changed the title Fixes #785 #785 Copy binaries to artifacts folder in build.sh Aug 26, 2014
@mbaker-dev
Copy link
Copy Markdown
Contributor Author

Hmm.. as this is currently written, it copies the mdb and pdb files as well. Should those have been excluded?

@adamralph
Copy link
Copy Markdown
Contributor

#785

@adamralph adamralph added this to the v1.0 milestone Oct 6, 2014
@adamralph adamralph removed this from the v1.0 milestone Nov 11, 2014
Copy binaries to artifacts folder in build.sh and create artifacts/bin folder if it doesn't exist.
@mbaker-dev
Copy link
Copy Markdown
Contributor Author

Rebased and squashed. Is there anything else I need to do?

@adamralph adamralph self-assigned this Dec 12, 2014
@adamralph
Copy link
Copy Markdown
Contributor

Thanks @mbaker-dev.

In the windows build (build.cmd), the binaries are copied to artifacts/Release/bin. Would you mind changing the path to match this? I think it's nice if build.cmd and build.sh having matching behaviour as much as possible.

@adamralph
Copy link
Copy Markdown
Contributor

Included in #946

@khellang khellang closed this Mar 3, 2015
@adamralph
Copy link
Copy Markdown
Contributor

Thanks @mbaker-dev - you've been added to https://github.com/scriptcs/scriptcs/wiki/Contributors 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants