Refactor PackageInstaller: add guard clauses and replace conditional with Where()#888
Merged
khellang merged 1 commit intoscriptcs:devfrom Jan 3, 2015
adamralph:refactor-package-installer
Merged
Refactor PackageInstaller: add guard clauses and replace conditional with Where()#888khellang merged 1 commit intoscriptcs:devfrom adamralph:refactor-package-installer
khellang merged 1 commit intoscriptcs:devfrom
adamralph:refactor-package-installer
Conversation
khellang
added a commit
that referenced
this pull request
Jan 3, 2015
Refactor PackageInstaller: add guard clauses and replace conditional with Where()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attention was drawn to this class by https://scan8.coverity.com:8443/reports.htm#v21582/p10801/fileInstanceId=3240400&defectInstanceId=1396801&mergedDefectId=96016
It's a false positive, but I spotted some low hanging fruit for refactoring, plus a couple of missing guard clauses.