There are plenty more opportunities to refactor and simplify the arguments implementation but I decide to draw a line under what I've done so far and send this PR, since we need to close #869 before the 0.13 release, and I need to get back onto #626 which also needs to be fixed for 0.13 to go live.

I did a test rebase of my work on closing #626 onto this branch and there were some tricky conflicts so I decide to resolve them and leave my work for #626 based on this branch.

This means the sooner we can get this PR merged the better, since it's now the blocker for all work required to push out 0.13.

BTW, the easiest way to review this PR may be one commit at a time, since each is well isolated with a specific purpose.

Removing nesting doesn't diff very well in general 😉

Some local diff apps do it quite well if you toggle off 'compare whitespace'. I sent a feature request to GitHub for that a while back but they've not responded so far.

That's actually very true! Tried https://github.com/scriptcs/scriptcs/pull/896/files?w=1, works like a charm. You knew about ?w=1, right?

I'd forgotten about it, but thanks for reminding me 😉. I guess it would ultra trivial to add a UI control for it then...

LOL. Yeah, it's really weird that it they haven't added it yet. The query param has been there for years.

@scriptcs/core I decided to remove the arguments/config file refactoring commits from this PR because they were bloating it and I think that whole space actually needs a re-write instead (see #897).

This PR is much simpler now and only contains one refactoring commit for the acceptance tests. Would anyone have time to look at it over the weekend?

Can anyone look at this? We need to move forward with the nightly because the situation with the folder migration is already starting to confuse people, e.g. scriptcs/scriptcs-samples#20.

Awesomeness dude. PR for #626 coming soon...
On 16 Jan 2015 09:26, "Kristian Hellang" [email protected] wrote:

Merged #896 #896.

—
Reply to this email directly or view it on GitHub
#896 (comment).