refactorings from active code review of PR 914#916
Merged
khellang merged 1 commit intoscriptcs:devfrom Feb 5, 2015
adamralph:914-active-review
Merged
refactorings from active code review of PR 914#916khellang merged 1 commit intoscriptcs:devfrom adamralph:914-active-review
khellang merged 1 commit intoscriptcs:devfrom
adamralph:914-active-review
Conversation
Contributor
Author
|
@glennblock just some minor refactorings which I made whist reviewing #914 (Not required for the 0.13.1 release.) |
internalised/privatised implementation details expanded parameter types made fields readonly converted simple delegates to expressions converted conditionals to LINQ calls converted for..each list add to AddRange() removed redundant code whitespace fixes added R# settings
khellang
added a commit
that referenced
this pull request
Feb 5, 2015
refactorings from active code review of PR 914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re #914
internalised/privatised implementation details
expanded parameter types
converted simple delegates to expressions
converted conditionals to LINQ calls
converted for..each list add to AddRange()
removed redundant code
whitespace fixes
added R# settings