Merged
Conversation
Added new IRepl interface that inherits from IScriptExecutor and adds a new method named Quit Updated the Execute method of IRepl to accept an instance of IRepl instead of IScriptExecutor Updated Repl to implement IRepl and the new Quit method, which calls Terminate() and Environment.Exit(0) Updated the Execute() method of the existing REPL commands to accept an instance of IRepl instead of IScriptExecutor Added a new ExitCommand that uses the new Repl.Quit() method to exit the REPL Updated RuntimeServices to bind IRepl to Repl Updated existing REPL command tests to pass in a mock of IRepl to IReplCommand.Execute instead of a mock of IScriptExecutor Added new tests to cover the new ExitCommand Conflicts: src/ScriptCs.Contracts/IRepl.cs test/ScriptCs.Core.Tests/ReplCommands/CdCommandTests.cs test/ScriptCs.Core.Tests/ReplCommands/ClearCommandTests.cs test/ScriptCs.Core.Tests/ReplCommands/CwdCommandTests.cs test/ScriptCs.Core.Tests/ReplCommands/InstallCommandTests.cs test/ScriptCs.Core.Tests/ReplCommands/ResetCommandTests.cs test/ScriptCs.Core.Tests/ReplTests.cs
The PromptsUserBeforeExiting() unit test was eternal looping since the Console.ReadLine() method was never stubbed to return a value
Contributor
|
fixes #427 |
Contributor
|
👍 nice! I've added #427 to the 0.14 release notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a rebased and slightly modded version of #823.
Adds
:exitto REPL