Skip to content

Add Apikey in generic webhook#1526

Merged
rfelber merged 7 commits intosecureCodeBox:mainfrom
srburton:add-identification-apikey
Feb 22, 2023
Merged

Add Apikey in generic webhook#1526
rfelber merged 7 commits intosecureCodeBox:mainfrom
srburton:add-identification-apikey

Conversation

@srburton
Copy link
Copy Markdown
Contributor

@srburton srburton commented Jan 2, 2023 •
edited
Loading

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@srburton srburton changed the title First commit Add Apikey in hook Jan 2, 2023
@srburton srburton marked this pull request as draft January 2, 2023 21:47
@srburton srburton changed the title Add Apikey in hook Add Apikey in generic webhook Jan 2, 2023
J12934
J12934 previously requested changes Jan 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the PR 🙌🚀

I think there a a couple of errors which would prevent this from working, I've noted them down in the review below.

Can you please also take a look at the DCO requirements listed here: https://github.com/secureCodeBox/secureCodeBox/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-and-licensing

I can't merge PRs without it.

srburton and others added 6 commits January 4, 2023 23:29
@srburton
First commit
1c3113f 
Signed-off-by: Renato Burton <[email protected]>
@srburton @J12934
Update hooks/generic-webhook/hook/hook.js
4f5c9fa 
Co-authored-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Renato Burton <[email protected]>
@srburton @J12934
Update hooks/generic-webhook/templates/webhook-hook.yaml
aac2aab 
Co-authored-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Renato Burton <[email protected]>
@srburton @J12934
Update hooks/generic-webhook/templates/webhook-hook.yaml
775183f 
Co-authored-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Renato Burton <[email protected]>
@srburton
Add suggestion by @J12934
b7489fd 
Signed-off-by: Renato Burton <[email protected]>
@srburton
Adding me as a contributor
c7dfaf3 
Signed-off-by: Renato Burton <[email protected]>
@srburton srburton force-pushed the add-identification-apikey branch from bef7de8 to c7dfaf3 Compare January 5, 2023 02:29
@rfelber rfelber added the hook Implement or update a hook label Jan 5, 2023
@rfelber rfelber added this to the v4.0.0 milestone Jan 5, 2023
@renatosazup
Copy link
Copy Markdown

renatosazup commented Jan 26, 2023 •
edited
Loading

@rseedorff, could you tell me the release forecast for version 4.0.0? thanks!!

@rfelber
Copy link
Copy Markdown
Member

rfelber commented Feb 21, 2023

Hi @renatosazup,
thanks for your question. We plan to release v4.0.0 of secureCodeBox in the next weeks 🤞
Can we merge your PR already, just asking because its marked as draft, but seems to be ready.

@renatosazup
Copy link
Copy Markdown

renatosazup commented Feb 22, 2023

@rseedorff you can merge yes, it's ready 😄

@rfelber rfelber marked this pull request as ready for review February 22, 2023 12:24
@rfelber rfelber merged commit 22aeed8 into secureCodeBox:main Feb 22, 2023
@renatosazup renatosazup mentioned this pull request Mar 27, 2023
Closed
@J12934 J12934 mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@J12934 J12934 J12934 left review comments

@rfelber rfelber rfelber approved these changes

+1 more reviewer

@renatosazup renatosazup renatosazup left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hook Implement or update a hook

Projects

secureCodeBox
Archived in project

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@srburton @renatosazup @rfelber @J12934