Skip to content

feat: set-container-userns default yes or no#2009

Draft
jherzstein wants to merge 5 commits intosecureblue:livefrom
jherzstein:feat/set-container-userns_default_yes_or_no
Draft

feat: set-container-userns default yes or no#2009
jherzstein wants to merge 5 commits intosecureblue:livefrom
jherzstein:feat/set-container-userns_default_yes_or_no

Conversation

@jherzstein
Copy link
Copy Markdown
Contributor

@jherzstein jherzstein commented Mar 5, 2026

See #1911

Just changes set-container-userns for now, but opens up all ask_yes_no or parse_basic_toggle prompts to allow a [y/N] or [Y/n] default if desired.

Please advise as to which other set scripts should have default yes or no. I believe that includes the following:

  • set-bluetooth-modules
  • set-brew
  • set-container-userns ([y/N] default for now)
  • set-dhcp-hostname-sending
  • set-kargs-hardening
  • set-unconfined-userns
  • set-xwayland

@jherzstein jherzstein changed the title Feat: set-container-userns default yes or no feat: set-container-userns default yes or no Mar 5, 2026
@jherzstein jherzstein force-pushed the feat/set-container-userns_default_yes_or_no branch 2 times, most recently from 2de803a to e0983d8 Compare March 5, 2026 04:01
@RoyalOughtness
Copy link
Copy Markdown
Collaborator

Why is it desirable to have a default for these? That seems like it would be a worse user experience because ujust set-x has no indication of what the default might be.

@jherzstein
Copy link
Copy Markdown
Contributor Author

Why is it desirable to have a default for these? That seems like it would be a worse user experience because ujust set-x has no indication of what the default might be.

If I'm understanding you correctly, if you're refering to the set-x comands not including set-container-userns, I am happy to keep the changes as is to stay within scope of #1911 to only show a default y/n for set-container-userns.

However, if the enhancement requested by #1911 is no longer desired, perhaps that issue should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants