Skip to content

chore: remove Qt5 from desktop images#2019

Open
underscorejoser wants to merge 1 commit intosecureblue:livefrom
underscorejoser:remove-qt5
Open

chore: remove Qt5 from desktop images#2019
underscorejoser wants to merge 1 commit intosecureblue:livefrom
underscorejoser:remove-qt5

Conversation

@underscorejoser
Copy link
Copy Markdown
Contributor

@underscorejoser underscorejoser commented Mar 7, 2026

Closes #1950

After looking back I noticed that only qt5-qtbase have/runs %postun so it's safe to use tsflags=noscripts, even on KDE. May need more testing to see if affects something but, by the looks of the packages it removes, it seems fine.

The %postun can be found here and my understanding is that it only remove the files links added. It's kinda weird to error out because it works fine on tradicional fedora and even when rpm-ostree override remove but if this is too hacky I can understand.

It's a little overwhelming because of the check to see if it actually founds Qt5 packages to not fail in the future, maybe could be simplified.
Currently unsure about removing files between /usr/etc/ and /etc/.

RoyalOughtness
RoyalOughtness reviewed Mar 9, 2026
View reviewed changes
Comment thread files/scripts/removeqt5.sh Outdated
RoyalOughtness
RoyalOughtness reviewed Mar 9, 2026
View reviewed changes
Comment thread files/scripts/removeqt5.sh Outdated
@underscorejoser underscorejoser marked this pull request as draft March 9, 2026 20:04
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 3, 2026 •
edited
Loading

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@underscorejoser
Copy link
Copy Markdown
Contributor Author

underscorejoser commented Apr 4, 2026

After more testing I found out the problem with qt5-qtbase's %postun failing
For some reason /var/lib/alternatives exists while building the image which leads to update-alternatives think it's the right place and skipping the logic to check if it's an ostree image to use the right path
Logic: https://github.com/fedora-sysv/chkconfig/blob/d00ad17ee7a8b8ac4f28d01a7edf3a8ca0d88af4/alternatives.c#L1513-L1527
It's a empty directory and should be safe to remove or even desired so update-alternatives can work properly

I also explicitly list all packages to remove although all of them would be removed just by removing qt5-qtbase, let me know what is preferred

@underscorejoser underscorejoser marked this pull request as ready for review April 4, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RoyalOughtness RoyalOughtness Awaiting requested review from RoyalOughtness RoyalOughtness is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT] Remove Qt 5

3 participants

@underscorejoser @RoyalOughtness @spaceoden