feat: use flatpak preinstall and set default apps#2122
feat: use flatpak preinstall and set default apps#2122underscorejoser wants to merge 1 commit intosecureblue:nextfrom
Conversation
Up to standards ✅🟢 Issues
|
| @@ -0,0 +1,4 @@ | |||
| [Flatpak Preinstall com.github.tchx84.Flatseal] | |||
| Branch=stable | |||
| IsRuntime=false | |||
There was a problem hiding this comment.
have you confirmed in testing that this overrides the desktop flatseal.preinstall?
Because the order is different in the recipe and will have to be swapped for this to work I think:
- from-file: common/common-modules.yml
- from-file: common/kinoite-modules.yml
- from-file: common/desktop-modules.yml
There was a problem hiding this comment.
There's currently an issue with flatseal being installed on kinoite images, I have created an override for flatseal on kinoite but the problem is the desktop module is run after the kinoite module, I thought desktop module is run before the desktop-specific module, I don't know if I can just reverse for all images.
Can I just swap it for all images?
There was a problem hiding this comment.
@underscorejoser oh whoops I missed that. We'd have to be very careful and comb through the codebase to make sure nothing is order-dependent. Simply rming the file before preinstalling when on a kinoite image is likely less brittle
There was a problem hiding this comment.
You mean doing this on secureblueflatpaksetup or separate? It's just that I don't know if it's possible to delete the file within the script
There was a problem hiding this comment.
hm yeah and if we wanted to do it in the build it would belong in kinoite-modules and then we're back at square 1. Hmmm.
9b8fcb1 to
e8cb0fe
Compare
|
Since the removal of cosmic player we need an alternative for cosmic |
Resolves #2014
PR for
nextbranch. This is a proposal to useflatpak preinstallfeature, this does not replacesecureblueflatpaksetup, it's still being used. This approach also allows users after they rebase to another image to runflatpak preinstalland install the default apps for the desktop.There's currently an issue with flatseal being installed on kinoite images, I have created an override for flatseal on kinoite but the problem is the desktop module is run after the kinoite module, I thought desktop module is run before the desktop-specific module, I don't know if I can just reverse for all images.
Also no apps is being preinstall on sericea images.