Fix issues to improve code quality#146
Closed
dolftax wants to merge 1 commit intosegmentio:masterfrom
Closed
Conversation
Also add DeepSource configuration to spot these issues in future pull requests Signed-off-by: Jai <[email protected]>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forked and ran analysis on this repository and found some issues in the code. I've gone ahead and fixed a few issues 🚀. Few more are left -- https://deepsource.io/gh/jaipradeesh/analytics-python/
To continue running analysis on every PR and flag these issues, just follow these simple steps:
.deepsource.tomlfor this repo which you can use directly.You can take a look at the Getting Started docs for the steps. The tool is completely free to use for Open Source projects.
Signed-off-by: Jai [email protected]