Skip to content

updating to spec 1.0#25

Merged
calvinfo merged 1 commit intomasterfrom
spec/update
Sep 5, 2014
Merged

updating to spec 1.0#25
calvinfo merged 1 commit intomasterfrom
spec/update

Conversation

@calvinfo
Copy link
Copy Markdown
Contributor

@calvinfo calvinfo commented Sep 5, 2014

This commit includes a number of significant changes:

  • updating the library to use the new spec
  • moving to analytics.write_key API
  • moving to a consumer in a separate thread
  • adding request retries
  • python 3 support
  • making analytics.flush() synchronous
  • adding full travis tests

@calvinfo
Copy link
Copy Markdown
Contributor Author

calvinfo commented Sep 5, 2014

@ivolo

@ivolo
Copy link
Copy Markdown
Contributor

ivolo commented Sep 5, 2014

BOMB DIGGITY dude. Looks really clean, I like the Consumer and Queue usage.

selfie-1

selfie-2

selfie-3

SHIP IT.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selfie-0

@gjohnson
Copy link
Copy Markdown

gjohnson commented Sep 5, 2014

LGTM (not much of a python person though haha).

@calvinfo calvinfo force-pushed the spec/update branch 2 times, most recently from 3739211 to 2430d5b Compare September 5, 2014 19:36
This commit includes a number of significant changes:

  - updating the library to use the new spec
  - moving to analytics.write_key API
  - moving to a consumer in a separate thread
  - adding request retries
  - python 3 support
  - making analytics.flush() synchronous
  - adding full travis tests
calvinfo pushed a commit that referenced this pull request Sep 5, 2014
@calvinfo calvinfo merged commit 1263fea into master Sep 5, 2014
@calvinfo calvinfo deleted the spec/update branch September 5, 2014 21:53
@calvinfo
Copy link
Copy Markdown
Contributor Author

calvinfo commented Sep 6, 2014

thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants