Don't include test module when installing#301
Closed
bwhmather-joivy wants to merge 1 commit intosendgrid:masterfrom
Closed
Don't include test module when installing#301bwhmather-joivy wants to merge 1 commit intosendgrid:masterfrom
bwhmather-joivy wants to merge 1 commit intosendgrid:masterfrom
Conversation
|
|
|
Helo @bwhmather-joivy, Thank you for the PR! Unfortunately, this is a duplicate: #300 That said, we greatly appreciate your support and look forward to future contributions! With Best Regards, Elmer |
Author
|
Oh dear, sorry. Only checked the open issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the sendgrid package is installed, calling
import testwill import the sendgrid module.This is likely to cause conflicts with other packages that use a top-level test module.
This patch adds the test module to the exclude list in
setup.pyso that it won't be bundled in built packages. This will fix the namespace issue, and reduce the installed size. It should not affect running the tests, as the tests will only ever be run from the unbuilt source.