Skip to content

Documented the new error handling functionality from python-http-client#481

Merged
thinkingserious merged 2 commits intosendgrid:masterfrom
mptap:document-error-handling
Oct 29, 2017
Merged

Documented the new error handling functionality from python-http-client#481
thinkingserious merged 2 commits intosendgrid:masterfrom
mptap:document-error-handling

Conversation

@mptap
Copy link
Copy Markdown

@mptap mptap commented Oct 28, 2017 •
edited
Loading

Fixes #442

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link
Copy Markdown

SendGridDX commented Oct 28, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mptap mptap mentioned this pull request Oct 28, 2017
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 28, 2017 •
edited
Loading

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #481   +/-   ##
=====================================
  Coverage      83%    83%           
=====================================
  Files          30     30           
  Lines        1024   1024           
  Branches      160    160           
=====================================
  Hits          850    850           
  Misses         84     84           
  Partials       90     90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35cc980...f15bb99. Read the comment docs.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 29, 2017
@thinkingserious thinkingserious merged commit 3ec799f into sendgrid:master Oct 29, 2017
@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Oct 29, 2017

Hello @mptap,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document the new error handling functionality from python-http-client

4 participants

@mptap @SendGridDX @codecov-io @thinkingserious