[Fix] Get correct number of header entries for subject sequences#156
Merged
h-2 merged 1 commit intoseqan:masterfrom Jan 30, 2020
Merged
[Fix] Get correct number of header entries for subject sequences#156h-2 merged 1 commit intoseqan:masterfrom
h-2 merged 1 commit intoseqan:masterfrom
Conversation
h-2
approved these changes
Jan 30, 2020
Member
h-2
left a comment
There was a problem hiding this comment.
LGTM, but does this intentionally only target the master branch (lambda2)?
Member
Author
Yes, only a problem in lambda2 as we directly access the sequences and not a length vector in lambda3. In lambda3 is a different bug in the bam header, though, that will be fixed by #157. |
Member
|
Note that we have increasing divergence between the branches. At some point, this needs to be synchronised again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For translated databases, the number of original sequence lengths was used to determine the header entries. The last entry of the original sequence lengths is however the sum, so one empty header line was accidentally created in this case.