Re-activate pre-scoring = 1 if no reduction is used#201
Merged
h-2 merged 1 commit intoseqan:masterfrom Jan 2, 2023
Merged
Conversation
h-2
requested changes
Jan 2, 2023
.gitmodules
Outdated
| [submodule "seqan"] | ||
| path = include/seqan | ||
| url = git://github.com/seqan/seqan.git | ||
| url = https://github.com/seqan/seqan.git |
Member
There was a problem hiding this comment.
Suggested change
| url = https://github.com/seqan/seqan.git | |
| url = ../../seqan/seqan.git |
While we are at it, we can just switch to relative syntax (this will preserve whatever protocol is used for the main repo).
src/shared_misc.hpp
Outdated
| #include <forward_list> | ||
| #include <sys/sysctl.h> | ||
|
|
||
| #if defined(__APPLE__) |
Member
There was a problem hiding this comment.
Suggested change
| #if defined(__APPLE__) | |
| #if __has_include(<sys/sysctl.h>) |
This header is also used by FreeBSD and potentially other systems; just not my Linux any more. Can you check if the proposed change works? It might still pick up the header on Linux, but it shouldn't...
h-2
approved these changes
Jan 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-activates the pre-scoring default for unreduced sequences as stated in the help message (mainly important for nucleotide mode). Additionally, some minor fixes that have been already adjusted in lambda3 but were missing in lambda2.