Skip to content

Bits2#212

Merged
sarahet merged 2 commits intoseqan:masterfrom
h-2:bits2
May 10, 2023
Merged

Bits2#212
sarahet merged 2 commits intoseqan:masterfrom
h-2:bits2

Conversation

@h-2
Copy link
Copy Markdown
Member

@h-2 h-2 commented May 8, 2023

We don't have tests on this branch, but I have done some local tests that all look fine.

To use a minimum bit-score and no e-value, add --e-value 100 --bit-score 42.

@sarahet Can you run the following on a uniref DB and one small query file (maybe just 5 or 10MB):

  1. lambda2 master branch with e-value 1e-4, one thread
  2. this branch with e-value 1-e4, one thread
  3. this branch with bit-score 60, one thread

The output of 1) and 2) should be identical. When filtering 1) for bitscore 60, the output should be very similar to 3 (ideally identical).
(This doesn't have to be on our benchmark server)

@h-2 h-2 requested a review from sarahet May 8, 2023 17:13
setMinValue(parser, "e-value", "0");
setMaxValue(parser, "e-value", "100");

addOption(parser, ArgParseOption(" ", "bit-score",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be an empty string

@sarahet
Copy link
Copy Markdown
Member

sarahet commented May 9, 2023

The output of 1) and 2) should be identical. When filtering 1) for bitscore 60, the output should be very similar to 3 (ideally identical).

1 and 2 are identical, 1 filtered for bitscore 60 is identical to 3 (one query, 10Mb with uniref)

@sarahet
Copy link
Copy Markdown
Member

sarahet commented May 9, 2023

To use a minimum bit-score and no e-value, add --e-value 100 --bit-score 42.

This is different to Lambda3, is that because otherwise it would be difficult to merge with Lambda2's code?

@h-2
Copy link
Copy Markdown
Member Author

h-2 commented May 10, 2023

To use a minimum bit-score and no e-value, add --e-value 100 --bit-score 42.

This is different to Lambda3, is that because otherwise it would be difficult to merge with Lambda2's code?

Yes, I would have had to change more code, and I wanted to keep all changes to lambda2 minimal.

Copy link
Copy Markdown
Member

@sarahet sarahet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahet sarahet merged commit b73ac2d into seqan:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants