Skip to content

Add PHP 7.1 and 7.2 to Travis test matrix#680

Merged
serbanghita merged 7 commits intoserbanghita:masterfrom
emirb:patch-1
Dec 4, 2017
Merged

Add PHP 7.1 and 7.2 to Travis test matrix#680
serbanghita merged 7 commits intoserbanghita:masterfrom
emirb:patch-1

Conversation

@emirb
Copy link
Copy Markdown

@emirb emirb commented Sep 14, 2017

No description provided.

Copy link
Copy Markdown
Owner

@serbanghita serbanghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know 5.3 is EOL, but we haven't upgraded Mobile_Detect code yet and people are still using that

@emirb
Copy link
Copy Markdown
Author

emirb commented Sep 15, 2017

All tests are passing now. I've changed configuration to use Ubuntu 12.04 LTS (precise) because it's the one that still supports 5.3. Also, changed to sudo: false to make use of containerised infrastructure in Travis.

@emirb
Copy link
Copy Markdown
Author

emirb commented Sep 27, 2017

@serbanghita bump

@JayBizzle
Copy link
Copy Markdown
Contributor

You could setup the testing matrix like this to only uses the Precise distro on the 5.3 tests. Also, nice to add the nightly builds with allowed failures and a fast finish

matrix:
  include:
    - php: 5.3
      dist: precise
    - php: 5.4
    - php: 5.5
    - php: 5.6
    - php: 7.0
    - php: 7.1
    - php: 7.2
    - php: nightly
  allow_failures:
    - php: nightly
  fast_finish: true

@emirb
Copy link
Copy Markdown
Author

emirb commented Oct 15, 2017

Thanks @JayBizzle, I updated .travis.yml accordingly.

@emirb
Copy link
Copy Markdown
Author

emirb commented Nov 30, 2017

Can this be merged @serbanghita?

@serbanghita serbanghita merged commit 7c92151 into serbanghita:master Dec 4, 2017
@serbanghita
Copy link
Copy Markdown
Owner

@emirb thank you 🍻

@emirb emirb deleted the patch-1 branch December 4, 2017 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants