Add PHP 7.1 and 7.2 to Travis test matrix#680
Merged
serbanghita merged 7 commits intoserbanghita:masterfrom Dec 4, 2017
emirb:patch-1
Merged
Add PHP 7.1 and 7.2 to Travis test matrix#680serbanghita merged 7 commits intoserbanghita:masterfrom emirb:patch-1
serbanghita merged 7 commits intoserbanghita:masterfrom
emirb:patch-1
Conversation
serbanghita
requested changes
Sep 15, 2017
Owner
serbanghita
left a comment
There was a problem hiding this comment.
I know 5.3 is EOL, but we haven't upgraded Mobile_Detect code yet and people are still using that
Author
|
All tests are passing now. I've changed configuration to use Ubuntu 12.04 LTS (precise) because it's the one that still supports 5.3. Also, changed to |
Author
|
@serbanghita bump |
etaba001
approved these changes
Sep 30, 2017
etaba001
approved these changes
Sep 30, 2017
etaba001
approved these changes
Sep 30, 2017
Contributor
|
You could setup the testing matrix like this to only uses the Precise distro on the 5.3 tests. Also, nice to add the nightly builds with allowed failures and a fast finish matrix:
include:
- php: 5.3
dist: precise
- php: 5.4
- php: 5.5
- php: 5.6
- php: 7.0
- php: 7.1
- php: 7.2
- php: nightly
allow_failures:
- php: nightly
fast_finish: true |
Author
|
Thanks @JayBizzle, I updated |
Author
|
Can this be merged @serbanghita? |
serbanghita
approved these changes
Dec 4, 2017
Owner
|
@emirb thank you 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.