Skip to content

Added missing samsung tablet SM-T585#712

Closed
leonrenkema wants to merge 2 commits intoserbanghita:masterfrom
leonrenkema:missing_samsung
Closed

Added missing samsung tablet SM-T585#712
leonrenkema wants to merge 2 commits intoserbanghita:masterfrom
leonrenkema:missing_samsung

Conversation

@leonrenkema
Copy link
Copy Markdown

@leonrenkema leonrenkema commented Jan 16, 2018

We found that SM-T585 is also used

@leonrenkema leonrenkema changed the title Added missing samsung table SM-T585 Added missing samsung tablet SM-T585 Jan 16, 2018
@serbanghita serbanghita self-assigned this Jan 16, 2018
@serbanghita serbanghita added this to the 2.8.31 milestone Jan 16, 2018
@ukko
Copy link
Copy Markdown

ukko commented Jan 18, 2018

Hello, could you add to your PR another tablet from the Samsung SM-T285

UserAgent: Mozilla/5.0 (Linux; Android 5.1.1; SAMSUNG SM-T285 Build/LMY47V) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/3.5 Chrome/38.0.2125.102 Safari/537.36"

@ukko ukko mentioned this pull request Jan 18, 2018
Closed
@ukko
Copy link
Copy Markdown

ukko commented Jan 22, 2018

@serbanghita
Hi, can you merge this PR?

@serbanghita
Copy link
Copy Markdown
Owner

serbanghita commented Jan 22, 2018

@ukko yes, I need to test it today. Thanks for providing the UA!

@ukko
Copy link
Copy Markdown

ukko commented Feb 5, 2018 •
edited
Loading

@serbanghita

Hi! Now you can merge?
cat from shrek

@gety9
Copy link
Copy Markdown

gety9 commented Feb 10, 2018

@serbanghita

Serban hi,

There are 35 open PRs and they are not merged, could you explain why?
Is it because they fail when you test PRs on your end?

IMPORTANT: I am not criticizing or saying that you should merge them, i am just trying to understand how you determine what should be merged and what not.

Thank you!

@ukko
Copy link
Copy Markdown

ukko commented Feb 16, 2018

plz plz plz

@serbanghita
Copy link
Copy Markdown
Owner

serbanghita commented Feb 22, 2018

🙏 Sorry for the delay, I'm on it

@rozailan
Copy link
Copy Markdown

rozailan commented Feb 22, 2018 via email

@rozailan
Copy link
Copy Markdown

rozailan commented Feb 22, 2018 via email

serbanghita added a commit that referenced this pull request Feb 26, 2018
@serbanghita
Added missing samsung tablet SM-T585 (#712)
adb882e
@serbanghita
Copy link
Copy Markdown
Owner

serbanghita commented Feb 26, 2018

@leonrenkema @ukko thank you for providing assistance for this issue 🍺
@gety9 most of the PRs don't follow the CONTRIBUTING guideline which make my job a lot harder to review them. If every PR would pass just like that, than this library wouldn't be so reliable. Also take into the account my own limitations as a person with personal life and job :) I'm working to improve my response time. Thanks for reminding me that!

@serbanghita
Copy link
Copy Markdown
Owner

serbanghita commented Feb 26, 2018

Solved in 2.8.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@serbanghita serbanghita

Labels

type: regex

Projects

None yet

Milestone

2.8.31

Development

Successfully merging this pull request may close these issues.

5 participants

@leonrenkema @ukko @serbanghita @gety9 @rozailan