[Fix #1226] Waiting for pending writes before close#1227
[Fix #1226] Waiting for pending writes before close#1227fjtirado merged 1 commit intoserverlessworkflow:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #1226 by ensuring that when persistence is active and the application is closed, the close() method waits for all pending asynchronous writes to complete before returning control to the caller.
Changes:
- Added
futuresMap.values().forEach(future -> future.join())inclose()to block until all pendingCompletableFuturewrites are finished.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
...i/src/main/java/io/serverlessworkflow/impl/persistence/DefaultPersistenceInstanceWriter.java
Outdated
Show resolved
Hide resolved
f8a30c3 to
8318ecf
Compare
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: fjtirado <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Fix #1226