Skip to content

feat(api): GCP Pub/Sub#22

Closed
nkemnitz wants to merge 1 commit intoseung-lab:masterfrom
ZettaAI:nkem-gcp-pubsub
Closed

feat(api): GCP Pub/Sub#22
nkemnitz wants to merge 1 commit intoseung-lab:masterfrom
ZettaAI:nkem-gcp-pubsub

Conversation

@nkemnitz
Copy link
Copy Markdown
Contributor

@nkemnitz nkemnitz commented Mar 5, 2020

PR adds support for Google's Pub/Sub queue

TODO: Add tests and maybe look into the missing features

@william-silversmith
Copy link
Copy Markdown
Contributor

william-silversmith commented Jul 24, 2020

Ah, I seem to have missed this. Is this Google's primary task queue? Seems like they also have https://cloud.google.com/tasks/

@william-silversmith
Copy link
Copy Markdown
Contributor

Seems like pubsub is more like what we want. https://cloud.google.com/tasks/docs/comp-pub-sub

@nkemnitz
Copy link
Copy Markdown
Contributor Author

Hmm, I think Pub/Sub is more similar to SQS than Cloud Tasks, but there is no 100% perfect match between Pub/Sub, Cloud Tasks, SQS and SNS...

Notable differences between Pub/Sub and SQS I remember I ran into: Pub/Sub allows huge payloads (10 MB), but the maximum lease time limit is much shorter (10 minutes, iirc).

@william-silversmith
Copy link
Copy Markdown
Contributor

I'm going to try to integrate this, but I'll probably have to do some radical surgery to this PR or open a new one due to the major refactoring that just happened.

@william-silversmith
Copy link
Copy Markdown
Contributor

Would you still be interested in integrating this Nico? Happy to do it, just want to make sure there's interest.

@william-silversmith
Copy link
Copy Markdown
Contributor

Pub/Sub support was integrated in #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants