Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
==========================================
- Coverage 97.14% 95.65% -1.49%
==========================================
Files 35 36 +1
Lines 1332 1336 +4
==========================================
- Hits 1294 1278 -16
- Misses 38 58 +20
Continue to review full report at Codecov.
|
nfischer
requested changes
Jul 7, 2021
Member
nfischer
left a comment
There was a problem hiding this comment.
Looks good! One small comment inline.
nfischer
approved these changes
Jan 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for part of #1013, and aims to implement
shell.errorCode(), similar toshell.error(). Please let me know if you'd like me to change something, and thank you for the chance to work on a new ShellJS feature!