Conversation
This fixes several issues with the cp -Ru test cases: * Originally, I noticed the touch syntax looked wrong * After fixing that, I was trying to figure out how the test case was even passing before. I realized one of the assertions was wrong (it was asserting sourceFile contents, but should have asserted destFile contents) * I realized the test should have created a nested destination directory; without proper nesting, the sourceFile never actually collided with destFile during the copy * Lastly, I swapped touch() usage to use hardcoded timestamps for test consistency
c67ae60 to
74a6a5a
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes several issues with the cp -Ru test cases:
even passing before. I realized one of the assertions was wrong (it
was asserting sourceFile contents, but should have asserted destFile
contents)
directory; without proper nesting, the sourceFile never actually
collided with destFile during the copy
consistency