Added -L to find to visit symlinked folders too.#1080
Merged
nfischer merged 1 commit intoshelljs:masterfrom Feb 25, 2022
Merged
Added -L to find to visit symlinked folders too.#1080nfischer merged 1 commit intoshelljs:masterfrom
nfischer merged 1 commit intoshelljs:masterfrom
Conversation
nfischer
reviewed
Feb 24, 2022
Member
nfischer
left a comment
There was a problem hiding this comment.
Thanks! This seems reasonable overall
nfischer
approved these changes
Feb 25, 2022
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1080 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 36 36
Lines 1354 1354
=======================================
Hits 1316 1316
Misses 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually find does not go inside a symlink that is a folder.
In order to preserve old behaviour, the -L flag has been introduced to modify the behaviour and enter symlink'ed folders.