Conversation
5bdaa6d to
2c18459
Compare
Member
Author
|
Previously attempted a fix on #1131, but I think I will close that and just iterate on this branch instead. |
No change to logic. This updates nyc (code coverage tool) to version 15, which works around a breaking change that snuck into the latest Node LTS versions. Unfortunately, this version of nyc appears to break Node 8 and 9. We need to work around this problem by skipping test coverage on those versions. Fixes #1130
2c18459 to
f5c6bb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change to logic. This updates nyc (code coverage tool) to version 15. The main goal is to work around a bug on the latest nodejs LTS versions.
This change indicates it only supports nodejs >= 8.9. Hopefully this is good enough for our purposes since ShellJS currently supports nodejs >= 8.
Fixes #1130