Fix Windows test errors in src/ls.js and test/cp.js.#1166
Merged
nfischer merged 1 commit intoshelljs:masterfrom Jun 23, 2024
Merged
Fix Windows test errors in src/ls.js and test/cp.js.#1166nfischer merged 1 commit intoshelljs:masterfrom
nfischer merged 1 commit intoshelljs:masterfrom
Conversation
nfischer
approved these changes
Jun 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1166 +/- ##
==========================================
- Coverage 97.28% 96.47% -0.81%
==========================================
Files 36 36
Lines 1361 1361
==========================================
- Hits 1324 1313 -11
- Misses 37 48 +11 ☔ View full report in Codecov by Sentry. |
Member
|
Looks good. The CI runs fail at the codecov step, but that's not the fault of your change. I manually checked that the tests all pass. |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows test errors in src/ls.js and test/cp.js. Full
npm run testnow runs clean on Windows 10.Relates to preparing for fast-glob, #1153 .