Skip to content

fix: add global.js and plugin.js to exports list#1196

Merged
nfischer merged 1 commit intomasterfrom
fix-explicit-export-modules
Mar 8, 2025
Merged

fix: add global.js and plugin.js to exports list#1196
nfischer merged 1 commit intomasterfrom
fix-explicit-export-modules

Conversation

@nfischer
Copy link
Copy Markdown
Member

@nfischer nfischer commented Mar 8, 2025

We intend for dependent projects to be able to import these files, so this adds them to the explicit list of supported exports.

Fixes #1195
Test: tested this by running shelljs-plugin-open's test suite.

We intend for dependent projects to be able to import these files, so
this adds them to the explicit list of supported exports.

Fixes #1195
Test: tested this by running shelljs-plugin-open's test suite.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (7d88393) to head (7a324fd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1196   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          35       35           
  Lines        1408     1408           
=======================================
  Hits         1371     1371           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfischer nfischer added the fix Bug/defect, or a fix for such a problem label Mar 8, 2025
@nfischer nfischer merged commit f08195a into master Mar 8, 2025
20 checks passed
@nfischer nfischer deleted the fix-explicit-export-modules branch March 8, 2025 23:39
@nfischer nfischer added this to the v0.9.x milestone Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug/defect, or a fix for such a problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERR_PACKAGE_PATH_NOT_EXPORTED for shelljs/plugin and shelljs/global

1 participant