Skip to content

Workaround codecov bug of miscalculation of coverage (#795)#838

Merged
nfischer merged 1 commit intoshelljs:masterfrom
dwi2:fix/795
Apr 23, 2018
Merged

Workaround codecov bug of miscalculation of coverage (#795)#838
nfischer merged 1 commit intoshelljs:masterfrom
dwi2:fix/795

Conversation

@dwi2
Copy link
Copy Markdown
Contributor

@dwi2 dwi2 commented Apr 22, 2018

This fixes #795 (actually, workarounds it.)
For detail, please refer to #795 (comment)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 22, 2018

Codecov Report

Merging #838 into master will increase coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #838     +/-   ##
========================================
+ Coverage   95.49%   95.8%   +0.3%     
========================================
  Files          34      34             
  Lines        1266    1262      -4     
========================================
  Hits         1209    1209             
+ Misses         57      53      -4
Impacted Files Coverage Δ
src/ls.js 100% <ø> (+8.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9035b27...5529f86. Read the comment docs.

@dwi2 dwi2 changed the title Add comment to workaround codecov bug of miscalculation of coverage Workaround codecov bug of miscalculation of coverage (#795) Apr 23, 2018
Copy link
Copy Markdown
Member

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for ls() on a symlink to a directory

3 participants