fix(exec): consistent error message for maxBuffer#919
Merged
Conversation
This explicitly checks for maxBuffer errors in exec-child.js and provides a consistent error message. This modifies the test to verify this. This also supports the change in Node v10, which emits this as a RangeError instead of a regular Error. Although the error message is now explicit, this is not part of our API, since it's just tacked onto the end of exec's stderr. Fixes #915
Codecov Report
@@ Coverage Diff @@
## master #919 +/- ##
==========================================
+ Coverage 97.32% 97.34% +0.01%
==========================================
Files 34 34
Lines 1271 1280 +9
==========================================
+ Hits 1237 1246 +9
Misses 34 34
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explicitly checks for maxBuffer errors in exec-child.js and
provides a consistent error message. This modifies the test to verify
this.
Although the error message is now explicit, this is not part of our API,
since it's just tacked onto the end of exec's stderr.
Fixes #915