Improve error messages thrown when json parsing fails#154
Merged
hubertpompecki merged 4 commits intomasterfrom Oct 3, 2018
Merged
Improve error messages thrown when json parsing fails#154hubertpompecki merged 4 commits intomasterfrom
hubertpompecki merged 4 commits intomasterfrom
Conversation
Contributor
Author
|
EDIT: I decided to use |
3b92e9c to
0409774
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the gem fails to parse json received from the back-end it throws errors looking like the following:
The message above does not include the malformed payload and the payload is not included in server logs either because we don't have logging enabled for the front-end.
This PR extends the json_api_client gem on which the flex-rub-gem relies to include malformed json bodies as Sentry context in any
JSON::ParserErrorerrors it throws.