Issue/163 update cart create method#164
Merged
RichardWatkins1 merged 22 commits intomasterfrom Nov 12, 2018
Merged
Conversation
iankduffy
approved these changes
Nov 12, 2018
praweb
approved these changes
Nov 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue
The attributes being sent by the gem were being overwritten so the initial line items never reached the backend in development mode.
The fix
merge the test: true into the attributes rather than overwrite them.
QA
Follow the steps on this PR - https://github.com/shiftcommerce/matalan-rails-site/pull/2686