Issue/172 update test order mode#173
Merged
RichardWatkins1 merged 16 commits intomasterfrom Apr 3, 2019
Merged
Conversation
praweb
approved these changes
Mar 29, 2019
iankduffy
approved these changes
Apr 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue #172
Once the deployment engine is updated to use the app setup api then apps will be built on heroku using the app.json schema. This means that all values must be a string or object and cannot be a boolean. The environment configurations that are submitted in the admin panel will be a string e.g TEST_ODER_MODE="true". In the ruby gem we are currently checking
test_order_mode == true, once this becomestest_order_mode == "true"it will become false and we will not be setting test orders.The fix
Update the conditional to checkout
== (true || "true"). This way the gem will work before the deployment engine is released and after.QA
See QA steps in this PR - https://github.com/shiftcommerce/matalan-rails-site/pull/3339