Merged
Conversation
… with additional changes by me, including running spotless properly.
CodeQL auto build is failing with a "Picked up JAVA_TOOL_OPTIONS:..." message, so let's try a plain old Maven build.
Ensure that the CodeQL workflow checks out enough git history to support the spotless ratchetFrom test in the Maven build.
Trivial grammar fix.
…ch-1 Update README.md
This reverts commit 70e7c48.
scripts to create several SAST reports
…ed with Benchmark to score it, run crawlers on it, etc. Those utilities are now in a seperate project called BenchmarkUtils. BenchmarkUtils produces a maven plugin that is now used by all the scoring and crawling scripts updated in this commit. You have to clone BenchmarkUtils, then run: mvn install, to get the plugin (which is built and installed locally).
Proxy Settings added to OWASP Benchmark Crawler to enable different hosts
Updated the Dockerfile to reflect the repo change to BenchmarkJava
…rying to identify the custom header for test cases that use that.
aronsky
requested changes
Dec 14, 2021
Collaborator
aronsky
left a comment
There was a problem hiding this comment.
This PR includes commits that aren't really a part of it, it's impossible to go over it clearly. Please take the commits that are actually part of this PR, and rebase them onto master. Otherwise, it's unmanageable.
Comment on lines
+40
to
+42
| #- name: Autobuild | ||
| # uses: github/codeql-action/autobuild@v1 | ||
|
|
Collaborator
There was a problem hiding this comment.
Commented out sections aren't needed. If this info is needed in the future, it can be found in git's history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'Intermediate' class is removed