22152 support hash for download attachment (and Pull #32 write directly to disk)#43
Merged
brandonvfx merged 6 commits intomasterfrom Jun 25, 2013
Merged
Conversation
add new exception ShotgunDownloadFileError Add support for passing in dict to download_attachment()
backwards compatible so still supports Attachment id. cleaned up error handling
Author
|
Oops, I had started this. I'll hold. |
brandonvfx
added a commit
that referenced
this pull request
Jun 25, 2013
…wnload_attachment 22152 support hash for download attachment (and Pull #32 write directly to disk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied modified version of Pull Request 32 as an option to
download_attachment()Added support for passing in a dict as main parameter to
download_attachment()while maintaining backwards compatibility for passing in anint(with or without keyword)tests.