Skip to content

UofT-DSI | python - Assignment 2#2

Open
sijiao-liu wants to merge 1 commit intomainfrom
assignment-2
Open

UofT-DSI | python - Assignment 2#2
sijiao-liu wants to merge 1 commit intomainfrom
assignment-2

Conversation

@sijiao-liu
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

  1. Redefine the all_paths as the ones provided doesn’t fit my situation, use .readlines() to return the full files as a list where each item is one line in the file, and write a for loop to iterate through the file read in and print each row.
  2. Use NumPy methods .max(), .min(), and .mean() to return the summary values.
  3. Call the function of patient_summary() to return an array of means and call the function of check_zero() to return a True or False value

What did you learn from the changes you have made?

Review and practice what have learned from classes, and clarify some unsure items

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

At part 3, the detect_problems() function, I tried to enter a variable after return instead leave it as it.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

At part 1, I have some hard time to understand why for row in contens: would loop from each element in contents.

How were these changes tested?

Check by running different scripts in VS Code.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@pedram-aliniaye-asli pedram-aliniaye-asli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a great job here!
Just a quick note: Please add comments to your code to make it clearer for other people and explain what is happening in your code.
Please go ahead and do the modifications and then close this pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants