@ddaspit reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Enkidu93)

src/SIL.Machine/PunctuationAnalysis/ParatextProjectQuoteConventionDetector.cs line 33 at r1 (raw file):

        public QuoteConventionAnalysis GetQuoteConventionAnalysis(
            QuoteConventionDetector handler = null,
            Dictionary<string, List<int>> includeChapters = null

It would be better if this were a read-only interface, if possible, i.e. IReadOnlyDictionary.

src/SIL.Machine/PunctuationAnalysis/UsfmStructureExtractor.cs line 26 at r1 (raw file):

        {
            _nextTextSegmentBuilder.AddPrecedingMarker(UsfmMarkerType.Chapter);
            _nextTextSegmentBuilder.SetChapter(int.Parse(number));

It might be safer to get the chapter number from state.VerseRef.

Reviewable status: 4 of 8 files reviewed, 2 unresolved discussions (waiting on @ddaspit)

src/SIL.Machine/PunctuationAnalysis/ParatextProjectQuoteConventionDetector.cs line 33 at r1 (raw file):

Done.

src/SIL.Machine/PunctuationAnalysis/UsfmStructureExtractor.cs line 26 at r1 (raw file):

Done. Put in a change to machine.py for consistency.

@ddaspit reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)