@ddaspit reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

src/SIL.Machine/Corpora/ScriptureRef.cs line 53 at r1 (raw file):

                return true;
            }
            catch

Is there a specific exception you can catch? Generally, it is not a good idea to use a bare catch statement, since it can mask unexpected errors.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Enkidu93)

src/SIL.Machine/Corpora/ScriptureRef.cs line 46 at r1 (raw file):

        }

        public static bool TryParse(string str, out ScriptureRef scriptureRef, ScrVers versification = null)

By convention, the out parameter goes at the end. You can use overloading if you need to.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ddaspit)

src/SIL.Machine/Corpora/ScriptureRef.cs line 46 at r1 (raw file):

I was curious about default parameter + out. Yeah, overloading makes sense. Thank you! Done.

src/SIL.Machine/Corpora/ScriptureRef.cs line 53 at r1 (raw file):

OK, yeah, I wasn't sure if this were an exception since we really don't want TryParse to throw. I added VerseRefException.

@ddaspit reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

src/SIL.Machine/Corpora/ScriptureRef.cs line 46 at r2 (raw file):

        }

        public static bool TryParse(string str, out ScriptureRef scriptureRef)

This method can just call the other method and pass in null for the versification parameter.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ddaspit)

src/SIL.Machine/Corpora/ScriptureRef.cs line 46 at r2 (raw file):

Oh yeah, good point - done

@ddaspit reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)